Coerce MCL exceedance value to float before comparison#106
Merged
Conversation
latest_value can be a str while mcl is a float, raising TypeError: '>' not supported between instances of 'str' and 'float'. Parse the value via _num() first; unparseable values yield no flag. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Your pull request is automatically being deployed to Dagster Cloud.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
dump_mcl_exceedance_collection(backend/persisters/ogc_features.py), the exceedance flag compared the rawlatest_valuedirectly against the floatmcl:latest_valuecan arrive as astrfrom some sources, sovalue > mclraised:which surfaced as a Dagster step failure on the
nm_mcl_exceedanceop.Fix
Coerce the value through the existing
_num()helper before comparing:Unparseable / missing values become
None→ no exceedance flag, matching prior missing-value behavior.Notes for reviewer
_num()helper (same module) rather than adding a new one.props[analyte](still the original value); only the comparison is hardened.